> As far as I can see that is very hard to do though, and not really worth
> it -- the notes can contain an arbitrary expression in general.
OK, your call.
> Not for stage 4 certainly.
If we go this way, is the bug a regression? If no, why rushing the fix?
> That moves those notes to i2notes, and then distribute_notes drops them?
That's not why I understand though. The code appends i2notes to i3notes and
distribute_notes will preserve them on i3:
/* Distribute all the LOG_LINKS and REG_NOTES from I1, I2, and I3. */
if (i3notes)
distribute_notes (i3notes, i3, i3, newi2pat ? i2 : NULL,
elim_i2, elim_i1, elim_i0);
so the notes are effectively moved from I2 to I3. distribute_notes will
indeed drop the non-trivial REG_EQUAL and REG_EQUIV notes so your code is very
likely OK, it's just the wording of the comment. No big deal I agree.
--
Eric Botcazou
