On Tue, Mar 01, 2016 at 07:39:18PM +0100, Martin Jambor wrote: > as Jakub requested, this patch deals with HSA "excess errors" in the > libgomp library testsuite by passing -Wno-hsa to all of them. IIUC, > that passing it in the second parameter of dg-runtest (as opposed to > the third) means that it will apply even tests that have their own > dg-options, which is presumably easier for everyone, provided that hsa > will get is own libgomp testsuite directories.
What is the difference betwee the $flags and $default-extra-cflags arguments to dg-runtest? You seem to stick -Wno-hsa into the former, which to me looks like it will be mentioned as part of the test names (e.g. when cycling through -O* options, -Wno-hsa would be printed along with -O2 etc.)? Is there any reason not to stick it into the last argument instead? Jakub