On 29 February 2016 at 05:28, kugan <kugan.vivekanandara...@linaro.org> wrote: > >> That looks better, but I think the unordered_remove will break operand >> sorting >> and thus you probably don't handle x + x + x + x + y + y + y + y + y + >> y + z + z + z + z >> optimally. >> >> I'd say you simply want to avoid the recursion and collect a vector of >> [start, end] pairs >> before doing any modification to the ops vector. > > > Hi Richard, > > Is the attached patch looks better? >
Minor comment, I've noticed typos in your updated comment: "There should be two multiplication left in test1 (inculding one generated" should be "There should be two multiplications left in test1 (including one generated" > Thanks, > Kugan