On March 8, 2016 7:20:50 PM GMT+01:00, Jakub Jelinek <ja...@redhat.com> wrote: >On Tue, Mar 08, 2016 at 07:11:45PM +0100, Richard Biener wrote: >> On March 8, 2016 7:04:37 PM GMT+01:00, Jakub Jelinek ><ja...@redhat.com> wrote: >> I believe the safest fix is to re-instantiate the compatibility check >by refactoring operand_equal_p to perform it on the full ref (but not >recursions where it would be redundant and maybe too conservative). >> I've noticed this as well when doing the last operand_equal_p >surgery, esp. The incomplete and bogus half-way type checking done at >its top. > >Even say for INTEGER_CST vs. INTEGER_CST? I thought we intentionally >ignore >the type there.
Yes, the equality of those is tested before the type checks. That'll make a refactoring a little tricky I guess. Richard. >Anyway, I can try to cook up some patch with a new OEP_ flag and gather >some >statistics on how often such a change would affect things (both in the >amount of 0 -> 1 returns and 1 -> 0 returns). > > Jakub
