On Wed, 16 Mar 2016, Tom de Vries wrote: > Hi, > > this patch fixes graphite PR68809, a 6 regression. > > The problem we run into is that we return true in same_close_phi_node for two > single-argument phis, one with an int 0 argument, and one with a char 0 > argument: > ... > _1 = PHI <(int)0> > _2 = PHI <(char)0> > ... > The result types of the two phis are not the same though. > > So when we replace uses of _1 by uses of _2 in remove_duplicate_close_phi, we > introduce type errors, which causes an ICE during gimple verification. > > The patch fixes this by testing for equality of the result type of the phis in > same_close_phi_node. > > Bootstrapped and reg-tested on x86_64. > > OK for stage4 trunk?
Please use types_compatible_p () rather than strict equality. Ok with that change. Richard.
