On 03/24/2016 11:32 AM, Aldy Hernandez wrote:
On x86, PIC_OFFSET_TABLE_REGNUM calls a function (ix86_use_pseudo_pic_reg) so its value can theoretically change between its first and second use in the following conditional:if ((unsigned) PIC_OFFSET_TABLE_REGNUM != INVALID_REGNUM && fixed_regs[PIC_OFFSET_TABLE_REGNUM]) Since the macro can return -1 on x86, the second use can cause an out of bounds access. In practice ix86_use_pseudo_pic_reg() is probably a pure function, since we really shouldn't be changing the semantics of the pic register mid-flight, but it's probably safer to just avoid calling the function twice. OK pending tests?
Ok for stage 1. Bernd
