Re: [PATCH 06/18] move reg_equivs out of gc memory

[Bernd Schmidt]

On 04/20/2016 08:22 AM, tbsaunde+...@tbsaunde.org wrote:
From: Trevor Saunders <tbsaunde+...@tbsaunde.org>
It used the gc vector type, but isn't marked as a gc route, and appears
to be manually managed, so it should be safe to use the normal heap
vector.

gcc/ChangeLog:

2016-04-19  Trevor Saunders  <tbsaunde+...@tbsaunde.org>

        * ira-emit.c (emit_move_list): Adjust.
        * ira.c (fix_reg_equiv_init): Likewise.
        (update_equiv_regs): Likewise.
        (ira): Likewise.
        (do_reload): Likewise.
        * reload.c (subst_reloads): Likewise.
        * reload.h (reg_equivs): Move to the normal heap.
        * reload1.c (grow_reg_equivs): Adjust.
        (reload): Likewise.
        (eliminate_regs_1): Likewise.
        (elimination_effects): Likewise.
        (init_eliminable_invariants): Likewise.
        (free_reg_equiv): Likewise.

I wonder whether this is really worth it. The improvement is marginal, 
and there is a real cost associated with patches such as this one when 
people need to work across multiple branches.


Bernd