On 03/28/2016 06:44 AM, Andi Kleen wrote:
This patch adds a new gcc-auto-profile script that figures out the
correct event and runs perf. The script is installed with on Linux systems.
That sounds useful, and I think we'll want to accept this.
So Linux just hardcodes installing the script, but it may fail at runtime.
For this reason it would probably be best to retain the documentation
for the old method alongside the new one.
+
+baseurl = "https://download.01.org/perfmon"
Slightly scary to see a random unknown download URL. Apparently it's an
Intel thing? Is this referenced somewhere on an intel.com web page?
E.g.
@smallexample
create_gcov --binary=your_program.unstripped --profile=perf.data \
- --gcov=profile.afdo
+ --gcov=profile.afdo -gcov_version 1
@end smallexample
@end table
Why this change? What does it do?
Why isn't the new script in contrib? Does it have to be in gcc to be
installed? As a target-specific thing it probably needs to live at least
inside config/.
Please review the patch yourself for proper sentences everywhere.
Bernd