On Fri, Apr 29, 2016 at 6:32 PM, H.J. Lu <hongjiu...@intel.com> wrote:
> Some PR target/70155 tests check for nonexistence of the *movdi_internal
> pattern. Since PIC leads to the *movdi_internal pattern, skip those
> tests if PIC is used.
>
> Tested on x86-64. OK for trunk?
IMO, it would be better to add condition to a scan-string directive:
/* { dg-final { scan-assembler-not "\\*movdi_internal" { target nonpic } } } */
This way we will still check for other patterns.
Patch is pre-approved.
Uros.
> H.J.
> ---
> * gcc.target/i386/pr70155-1.c: Likewise.
> * gcc.target/i386/pr70155-2.c: Likewise.
> * gcc.target/i386/pr70155-3.c: Likewise.
> * gcc.target/i386/pr70155-4.c: Likewise.
> * gcc.target/i386/pr70155-5.c: Likewise.
> * gcc.target/i386/pr70155-6.c: Likewise.
> * gcc.target/i386/pr70155-7.c: Likewise.
> * gcc.target/i386/pr70155-8.c: Likewise.
> * gcc.target/i386/pr70155-15.c: Likewise.
> * gcc.target/i386/pr70155-17.c: Likewise.
> * gcc.target/i386/pr70155-22.c: Likewise.
> ---
> gcc/testsuite/gcc.target/i386/pr70155-1.c | 1 +
> gcc/testsuite/gcc.target/i386/pr70155-15.c | 1 +
> gcc/testsuite/gcc.target/i386/pr70155-17.c | 1 +
> gcc/testsuite/gcc.target/i386/pr70155-2.c | 1 +
> gcc/testsuite/gcc.target/i386/pr70155-22.c | 1 +
> gcc/testsuite/gcc.target/i386/pr70155-3.c | 1 +
> gcc/testsuite/gcc.target/i386/pr70155-4.c | 1 +
> gcc/testsuite/gcc.target/i386/pr70155-5.c | 1 +
> gcc/testsuite/gcc.target/i386/pr70155-6.c | 1 +
> gcc/testsuite/gcc.target/i386/pr70155-7.c | 1 +
> gcc/testsuite/gcc.target/i386/pr70155-8.c | 1 +
> 11 files changed, 11 insertions(+)
>
> diff --git a/gcc/testsuite/gcc.target/i386/pr70155-1.c
> b/gcc/testsuite/gcc.target/i386/pr70155-1.c
> index 3500364..b441c16 100644
> --- a/gcc/testsuite/gcc.target/i386/pr70155-1.c
> +++ b/gcc/testsuite/gcc.target/i386/pr70155-1.c
> @@ -1,4 +1,5 @@
> /* { dg-do compile { target int128 } } */
> +/* { dg-require-effective-target nonpic } */
> /* { dg-options "-O2 -msse2 -mtune=generic -dp" } */
>
> extern __int128 a, b;
> diff --git a/gcc/testsuite/gcc.target/i386/pr70155-15.c
> b/gcc/testsuite/gcc.target/i386/pr70155-15.c
> index e9cafcc..c3e8e7b 100644
> --- a/gcc/testsuite/gcc.target/i386/pr70155-15.c
> +++ b/gcc/testsuite/gcc.target/i386/pr70155-15.c
> @@ -1,4 +1,5 @@
> /* { dg-do compile { target int128 } } */
> +/* { dg-require-effective-target nonpic } */
> /* { dg-options "-O2 -msse2 -mtune=core2
> -mtune-ctrl=sse_unaligned_store_optimal -dp" } */
>
> struct foo
> diff --git a/gcc/testsuite/gcc.target/i386/pr70155-17.c
> b/gcc/testsuite/gcc.target/i386/pr70155-17.c
> index a9427e6..675239a 100644
> --- a/gcc/testsuite/gcc.target/i386/pr70155-17.c
> +++ b/gcc/testsuite/gcc.target/i386/pr70155-17.c
> @@ -1,4 +1,5 @@
> /* { dg-do compile { target int128 } } */
> +/* { dg-require-effective-target nonpic } */
> /* { dg-options "-O2 -msse2 -mtune=generic -dp" } */
>
> extern __int128 a, b, c, d, e, f;
> diff --git a/gcc/testsuite/gcc.target/i386/pr70155-2.c
> b/gcc/testsuite/gcc.target/i386/pr70155-2.c
> index af2ddc6..b9b0c28 100644
> --- a/gcc/testsuite/gcc.target/i386/pr70155-2.c
> +++ b/gcc/testsuite/gcc.target/i386/pr70155-2.c
> @@ -1,4 +1,5 @@
> /* { dg-do compile { target int128 } } */
> +/* { dg-require-effective-target nonpic } */
> /* { dg-options "-O2 -msse2 -mtune=generic -dp" } */
>
> struct foo
> diff --git a/gcc/testsuite/gcc.target/i386/pr70155-22.c
> b/gcc/testsuite/gcc.target/i386/pr70155-22.c
> index ff5cbce..83fdbe6 100644
> --- a/gcc/testsuite/gcc.target/i386/pr70155-22.c
> +++ b/gcc/testsuite/gcc.target/i386/pr70155-22.c
> @@ -1,4 +1,5 @@
> /* { dg-do compile { target int128 } } */
> +/* { dg-require-effective-target nonpic } */
> /* { dg-options "-O2 -msse2 -mtune=generic -dp" } */
>
> extern __int128 a, b, c;
> diff --git a/gcc/testsuite/gcc.target/i386/pr70155-3.c
> b/gcc/testsuite/gcc.target/i386/pr70155-3.c
> index 01b38aa..88acbac 100644
> --- a/gcc/testsuite/gcc.target/i386/pr70155-3.c
> +++ b/gcc/testsuite/gcc.target/i386/pr70155-3.c
> @@ -1,4 +1,5 @@
> /* { dg-do compile { target int128 } } */
> +/* { dg-require-effective-target nonpic } */
> /* { dg-options "-O2 -msse2 -mtune=generic -dp" } */
>
> extern __int128 a;
> diff --git a/gcc/testsuite/gcc.target/i386/pr70155-4.c
> b/gcc/testsuite/gcc.target/i386/pr70155-4.c
> index 31bc0a7..7f4ad9c 100644
> --- a/gcc/testsuite/gcc.target/i386/pr70155-4.c
> +++ b/gcc/testsuite/gcc.target/i386/pr70155-4.c
> @@ -1,4 +1,5 @@
> /* { dg-do compile { target int128 } } */
> +/* { dg-require-effective-target nonpic } */
> /* { dg-options "-O2 -msse2 -mtune=generic -dp" } */
>
> extern __int128 a;
> diff --git a/gcc/testsuite/gcc.target/i386/pr70155-5.c
> b/gcc/testsuite/gcc.target/i386/pr70155-5.c
> index 9647452..570d2f4 100644
> --- a/gcc/testsuite/gcc.target/i386/pr70155-5.c
> +++ b/gcc/testsuite/gcc.target/i386/pr70155-5.c
> @@ -1,4 +1,5 @@
> /* { dg-do compile { target int128 } } */
> +/* { dg-require-effective-target nonpic } */
> /* { dg-options "-O2 -msse2 -mtune=generic -dp" } */
>
> extern __int128 a;
> diff --git a/gcc/testsuite/gcc.target/i386/pr70155-6.c
> b/gcc/testsuite/gcc.target/i386/pr70155-6.c
> index 7e074a73..6feb481 100644
> --- a/gcc/testsuite/gcc.target/i386/pr70155-6.c
> +++ b/gcc/testsuite/gcc.target/i386/pr70155-6.c
> @@ -1,4 +1,5 @@
> /* { dg-do compile { target int128 } } */
> +/* { dg-require-effective-target nonpic } */
> /* { dg-options "-O2 -msse2 -mtune=generic -dp" } */
>
> extern __int128 a;
> diff --git a/gcc/testsuite/gcc.target/i386/pr70155-7.c
> b/gcc/testsuite/gcc.target/i386/pr70155-7.c
> index 93c6fc0..565525d 100644
> --- a/gcc/testsuite/gcc.target/i386/pr70155-7.c
> +++ b/gcc/testsuite/gcc.target/i386/pr70155-7.c
> @@ -1,4 +1,5 @@
> /* { dg-do compile { target int128 } } */
> +/* { dg-require-effective-target nonpic } */
> /* { dg-options "-O2 -msse2 -mtune=generic -dp" } */
>
> struct foo
> diff --git a/gcc/testsuite/gcc.target/i386/pr70155-8.c
> b/gcc/testsuite/gcc.target/i386/pr70155-8.c
> index f304a4e..b0c0bfc 100644
> --- a/gcc/testsuite/gcc.target/i386/pr70155-8.c
> +++ b/gcc/testsuite/gcc.target/i386/pr70155-8.c
> @@ -1,4 +1,5 @@
> /* { dg-do compile { target int128 } } */
> +/* { dg-require-effective-target nonpic } */
> /* { dg-options "-O2 -msse2 -mtune=generic -dp" } */
>
> struct foo
> --
> 2.5.5
>
