On 05 May 11:56, Jakub Jelinek wrote: > On Thu, May 05, 2016 at 12:49:57PM +0300, Kirill Yukhin wrote: > > Hi Jakub, > > On 03 May 20:57, Jakub Jelinek wrote: > > > This patch improves code generation e.g. on the first attached testcase > > > and allows accepting the second one. > > > > > > I've noticed we don't allow TFmode or V1TImode in xmm16+ regs at all, > > > while they are allowed in xmm0-xmm15, so IMHO should be ok even with > > > AVX512VL. > > > > > > Wonder if it wouldn't be better to add a new constraint that would act > > > like v constraint for TARGET_AVX512VL and like x constraint otherwise, > > > that might greatly simplify the i386.md changes in this patch. > > Good idea, I thought about that myself. IMHO this might be a follow up. > > Ok, will add that to todo. > > > > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk, > > > or with some changes? Haven't figured out how to test the *andnot* > > > and *<logic>* patterns though. > > Are you going to commit testcases? > > I didn't mean to in this case, but guess I could (as for the other patches, > dg-do assemble only, I think trying to scan the assembly might be too fragile, > it is up to the RA to decide). > > > Yeah, tests for FP *logic* look odd, so I am OK for not having them. > > So, is the patch ok for trunk with the two testcases turned into > dg-do assemble tests, or do you want me to repost with that, or add the > Yv constraint right away, something else? Nope. Patch is pre-OK. Thanks! > > Jakub
-- K
