On Tue, Mar 29, 2016 at 05:48:25PM +0800, Chung-Lin Tang wrote:
> I've updated this patch for trunk (as attached), and re-tested without
> regressions. This patch is still a fix for
> libgomp.oacc-c-c++-common/asyncwait-1.c,
> which FAILs right now.
>
> ChangeLog is still as before. Is this okay for trunk?
Mostly ok for trunk, but as it is an ABI incompatible change for the plugin
interface (affecting OpenACC capable plugins only), I think you just should
rename the plugin callback you add the argument to, so that
|| !DLSYM_OPT (openacc.register_async_cleanup,
openacc_register_async_cleanup)
would fail when trying to load GCC 6.x nvptx plugin from GCC 7.x libgomp
or vice versa.
Jakub
