On Wed, May 11, 2016 at 03:23:50PM +0200, Christophe Lyon wrote:
> Hi,
>
> A few months ago, we decided it was time to remove neon-testgen.ml
> and its generated tests. I did it, just to realize too late that
> some intrinsics were not covered anymore, so I reverted the removal.
>
> This patch series performs a little bit of cleanup and adds the
> missing tests to cover all what is defined in arm_neon.h for AArch32.
>
> Globally, this consists in adding tests for:
> - missing poly8 and poly16 for vreinterpret and vtst
> - fp16 tests for vget_lane, vstX_lane and vreinterpret
> - armv8 vrnd{,a,m,n,p,x}
> - tests for poly64 and poly128 intrinsics
>
> Some intrinsics are not covered in aarch64/advsimd-intrinsics, but in
> arm/crypto: vldrq, vstrq, vaes, vsha1, vsha256, vmull_p64,
> vmull_high_p64.
>
> Patches 1-4 are cleanup.
> Patch 5 adds the missing poly8 and poly16 tests for vreinterpret.
> Patch 6 adds the missing tests for vtst_p8 and vtstq_p8.
> Patches 7,8, 11 add the missing fp16 tests
> Patch 9 adds armv8 vrnd{,a,m,n,p,x} tests
> Patch 10 adds tests for poly64 and poly128 operations
>
> I've checked the coverage by building the list of intrinsics tested
> via neon-testgen.ml, the list of intrinsics defined in arm_neon.h, and
> running the advsimd-intrinsics.exp tests with -save-temps to gather
> the list of actually tested intrinsics.
>
> This series partly addresses PR 70369 which I created to keep track
> of these missing intrinsics tests: several AArch64 AdvSIMD intrinsics
> are still missing tests.
>
> Tested with QEMU on arm* and aarch64*, with no regression, and
> several new PASSes.
>
> OK for trunk?
D'oh, I wasn't thinking when I started OKing these, but obviously I only
have the privilege to OK them from an AArch64 perspective.
If it isn't too late, please wait for someone from the ARM port to give
their blessing before committing them.
Sorry to the ARM maintainers for forgetting to be explicit about that in
my earlier emails.
Thanks,
James
