On 05/19/2016 12:40 PM, Aaron Conole wrote:
Nathan Sidwell <nat...@acm.org> writes:
On 02/24/16 16:52, Aaron Conole wrote:
The previous gcov behavior was to always output errors on the stderr channel.
This is fine for most uses, but some programs will require stderr to be
untouched by libgcov for certain tests. This change allows configuring
the gcov output via an environment variable which will be used to open
the appropriate file.
this is ok in principle. I have a couple of questions & nits below though.
Thank you for the consideration. I will be submitting a new patch that
I hope fully addresses your comments below, either tomorrow or Monday.
Thanks so much for the review.
I don't see a previous commit from you -- do you have a copyright
assignment with the FSF? (although this patch is simple, my guess is
the idea it implements is sufficiently novel to need one). We can
handle that off list.
I'm happy to report that I did send in some FSF paperwork this week.
Hopefully it is on record now, but even if it isn't I live a train ride
away from the FSF headquarters so I'd be happy to take the time to make
sure it's all signed correctly.
Also note that Aaron works for Red Hat and should be covered by our
existing assignments.
jeff
