On Sat, May 21, 2016 at 10:55:21PM +0200, Bernhard Reutner-Fischer wrote:
> >@@ -313,6 +332,7 @@ proc profopt-execute { src } {
> >     # valid, by running it after dg-additional-files-options.
> >     foreach ext $prof_ext {
> >         profopt-target-cleanup $tmpdir $base $ext
> >+        profopt-target-cleanup $tmpdir perf data
> >     }
> 
> I think I've asked this before.. Why do you need to run cleanup of perf data 
> in this loop (and not outside)?
> Also why the asymmetry ...

perf generates a backup file if a file already exists. 

> >@@ -399,7 +460,9 @@ proc profopt-execute { src } {
> >     # Remove the profiling data files.
> >     foreach ext $prof_ext {
> >         profopt-target-cleanup $tmpdir $base $ext
> >+        profopt-target-cleanup $tmpdir perf data
> >     }
> >+    file delete "perf.data" 

The extra one is not needed. I'll remove it.

Thanks
-Andi

-- 
a...@linux.intel.com -- Speaking for myself only.

Reply via email to