> > Hmm, you are probably right. If we can have array with TYPE_DOMAIN != NULL
> > and sane bounds, but with TYPE_SIZE == NULL, we probably need to punt on
> > NULL
> > TYPE_SIZE. I can add it just to be sure.
>
> As a MEM_REF embeds a VIEW_CONVERT you can placement-new
>
> struct { int a[5]; char b[]; };
Yep. This is what I am trying to handle with the TYPE_SIZE condition.
>
> ontop of char X[24]; and access MEM_REF[&x].a[3] (not at struct end)
> and MEM_REF[&x].b[4] but _both_ accesses would have TYPE_SIZE NULL.
>
> So I'm not sure TYPE_SIZE tells you anything here...
Well, here when parsing MEM_REF[&x].a[3] array_at_struct_end_p should return
true because it parses the handled components and will see FIELD_REF for .a
that is not at end:
while (handled_component_p (ref))
{
/* If the reference chain contains a component reference to a
non-union type and there follows another field the reference
is not at the end of a structure. */
if (TREE_CODE (ref) == COMPONENT_REF
&& TREE_CODE (TREE_TYPE (TREE_OPERAND (ref, 0))) == RECORD_TYPE)
{
tree nextf = DECL_CHAIN (TREE_OPERAND (ref, 1));
while (nextf && TREE_CODE (nextf) != FIELD_DECL)
nextf = DECL_CHAIN (nextf);
if (nextf)
return false;
}
ref = TREE_OPERAND (ref, 0);
}
The size compare is meant to make difference between
struct a { int a[5]; char b[5]; };
placed in char buf[sizeof(struct a)]
or in placed in char buf[sizeof(struct a)+5]
The REF seen at this pace is the REF of ourter type after unwinding handled
compoennts,
so it should have TYPE_SIZE defined in this case I think.
Honza
>
> Richard.
>
> > I am testing
> >
> > Index: tree.c
> > ===================================================================
> > --- tree.c (revision 236557)
> > +++ tree.c (working copy)
> > @@ -13079,7 +13079,8 @@ array_at_struct_end_p (tree ref)
> > tree size = NULL;
> >
> > if (TREE_CODE (ref) == MEM_REF
> > - && TREE_CODE (TREE_OPERAND (ref, 0)) == ADDR_EXPR)
> > + && TREE_CODE (TREE_OPERAND (ref, 0)) == ADDR_EXPR
> > + && TYPE_SIZE (TREE_TYPE (ref)))
> > {
> > size = TYPE_SIZE (TREE_TYPE (ref));
> > ref = TREE_OPERAND (TREE_OPERAND (ref, 0), 0);
> >
> >
>
> --
> Richard Biener <rguent...@suse.de>
> SUSE LINUX GmbH, GF: Felix Imendoerffer, Jane Smithard, Graham Norton, HRB
> 21284 (AG Nuernberg)
