Hi!
On Thu, Jun 02, 2016 at 06:28:21PM -0600, Martin Sebor wrote:
First of all, can you please respond to the mail I've sent about
NULL argument issues (and proposal for __builtin_*_overflow_p)?
This patch as well as the nonnull attribute patch then depends on that
decision...
> + {
> + tree type = TREE_TYPE (TREE_TYPE (t));
> + tree vflow = arith_overflowed_p (opcode, type, arg0, arg1)
> + ? integer_one_node : integer_zero_node;
This looks incorrect, the return type is TREE_TYPE (t), some complex integer
type, therefore vflow needs to be
tree vflow = build_int_cst (TREE_TYPE (TREE_TYPE (t)),
arith_overflowed_p (opcode, type, arg0, arg1)
? 1 : 0);
no?
Jakub
