On 06/13/16 17:27, David Malcolm wrote: > On Mon, 2016-06-13 at 14:41 +0000, Bernd Edlinger wrote: >> Hi, >> >> as noted in PR bootstrap/71481, comment#4 currently >> the trunk fails to bootstrap if the current language is >> not english. A workaround is possible by setting LANG=C, >> but OTOH it is rather easy to fix, by translating the string >> in the assertion, as it is the only place that is affected by >> the language setting. >> >> >> Boot-strapped and reg-tested on trunk with LANG=de_DE.UTF-8. >> OK to commit? > > Sorry about the breakage. > > I believe I can approve this with my "libcpp"/"diagnostics" hats on, so > LGTM. >
Thanks. > That said, should we hardcode LANG=C when running the selftests from > gcc/Makefile.in? > Honestly, I am glad to see that there is some sort of unit test which runs in a different LANG setting than the rest of the testsuite. Because as this incident clearly shows, there _can_ be bugs that do not show up in the default locale. I would put the question this way: could it be possible to run also some tests in the testsuite with a LANG setting different from "C"? Bernd.
