Hi Christophe,
On 17/06/16 11:47, Christophe Lyon wrote:
Hi,
As discussed some time ago with Kyrylo (on IRC IIRC), the attached
patch makes sure that arm_neon_fp16_ok and arm_neonv2_ok effective
targets imply that arm_neon_ok passes, and use the corresponding
flags.
Without this patch, the 3 effective targets have different, possibly
inconsistent conditions. For instance, arm_neon_ok make sure that
__ARM_ARCH >= 7, but arm_neon_fp16_ok does not.
This led to failures on configurations not supporting neon, but where
arm_neon_fp16_ok passes as the test is less strict.
Rather than duplicating the same tests, I preferred to call
arm_neon_ok from the other places.
We then use the union of flags needed for arm_neon_ok and
arm_neon_fp16_ok to pass.
Tested on many arm configurations with no harm. It prevents
arm_neon_fp16 tests from passing when forcing -march=armv5t, that
seems coherent.
OK?
Ok with a ChangeLog nit below.
Thanks,
Kyrill
Christophe
2016-06-17 Christophe Lyon<christophe.l...@linaro.org>
* lib/target-supports.exp
(check_effective_target_arm_neon_fp16_ok_nocache): Call
arm_neon_ok and merge flags. Fix temporary test name.
I believe the rule in ChangeLogs is also to use two spaces after a full stop.
So two spaces before "Fix temporary..."
