On 21 June 2016 at 15:13, Jakub Jelinek <ja...@redhat.com> wrote: > On Tue, Jun 21, 2016 at 03:10:33PM +0200, Christophe Lyon wrote: >> > Here is a new patch version, which removes the hardcoded dg-do run >> > directives, >> > so that tests use compile or run depending on the result of >> > check_vect_support_and_set_flags. >> > >> > On ARM, this first uses arm_neon_ok to detect the required flags, then >> > depending on >> > arm_neon_hw, it decides whether to dg-do run or compile. >> > >> > OK? >> >> ping? > > I'm not convinced we want to do this, even if the hw doesn't support it, the > dg-do run tests are tested for not just compilation, but also assembly and > linking; IMHO much better is to really fix up > check_vect so that it works on ARM as it does everywhere else, even if it > just means rewriting parts of it in inline asm. >
I'm not sure to follow: many other targets use dg-do compile if some "hw" support is not present (see check_vect_support_and_set_flags for powerpc, sparc, alpha, x86). Do you mean that on these targets, we want to run the tests, even if the hw does not support the required features and that removing dg-do run will result is less coverage on these targets? What about defaulting to 'assemble' instead of 'compile' ? > Jakub
