On Sat, Jun 25, 2016 at 07:14:01PM -0500, Peter Bergner wrote: > This patch fixes PR71656 by adding support to rs6000_legitimize_reload_address > for POWER9 vector-dform addresses. Previously, -mpower9-dform-vector was > disabled when using reload due to this bug and it was not added to the default > ISA 3.0 flags. Now that -mpower9-dform-vector works with reload, I have > added it to the default ISA 3.0 flags and removed the disabling of the > option when using -mno-lra. I also updated rs6000_legitimate_address_p > so that it too correctly handles quad addresses. > > This has bootstrapped and regtested with no regessions on powerpc64le-linux. > Ok for for trunk? > > This bug also affects the FSF 6 branch. Ok for that branch after the patch > has burned in a while on trunk and after the usual bootstrap and regtesting?
Okay for trunk, okay for 6 later. One comment: > + if (VECTOR_MODE_P (mode) > + && !mode_supports_vsx_dform_quad (mode)) > + return false; > > if (GET_CODE (addr) != PLUS) > return false; > > op0 = XEXP (addr, 0); > - if (!base_reg_operand (op0, Pmode)) > + if (!REG_P (op0) > + || !INT_REG_OK_FOR_BASE_P (op0, strict)) > return false; Just put these short conditionals on one line each? It looks silly ;-) Thanks, Segher