On 07/01/2016 04:31 PM, Dominik Vogt wrote: > The attached patch adds patterns to make use of the z13 LOCHI and > LOCGHI instructions. > > Tested on s390x biarch and s390, regression tested on s390x. > > Ciao > > Dominik ^_^ ^_^ >
Looks good, thanks! Could you try merging the two testcases into one by putting the lp64 and ! lp64 as condition on the scan assembler expressions? Also I don't think it is really necessary to have these multiline matching checks in such a small test. It should be enough to just make sure that the expected mnemonic occurs somewhere. Sure this wouldn't catch cases where e.g. the mnemonics are in the asm file but not in the right function but I think the risk should be really low here. Bye, -Andreas-
