On 15/07/16 18:05, Aldy Hernandez wrote:
+ case OPT_Walloca_larger_than_:
+ if (!value)
+ inform (loc, "-Walloca-larger-than=0 is meaningless");
+ break;
+
+ case OPT_Wvla_larger_than_:
+ if (!value)
+ inform (loc, "-Wvla-larger-than=0 is meaningless");
+ break;
+
We don't give similar notes for any of the other Wx-larger-than= options. If
-Wvla-larger-than=0 suppresses a previous -Wvla-larger-than=, then it doesn't
seem meaningless, but a useful thing to have.
+ if (is_vla)
+ gcc_assert (warn_vla_limit > 0);
+ if (!is_vla)
+ gcc_assert (warn_alloca_limit > 0);
if-else ? Or perhaps:
gcc_assert (!is_vla || warn_vla_limit > 0);
gcc_assert (is_vla || warn_alloca_limit > 0);
--- a/gcc/c-family/c.opt
+++ b/gcc/c-family/c.opt
@@ -275,6 +275,15 @@ Wall
C ObjC C++ ObjC++ Warning
Enable most warning messages.
+Walloca
+C ObjC C++ ObjC++ Var(warn_alloca) Warning
+
+Walloca-larger-than=
+C ObjC C++ ObjC++ Var(warn_alloca_limit) Warning Joined RejectNegative UInteger
+-Walloca-larger-than=<number> Warn on unbounded uses of
+alloca, and on bounded uses of alloca whose bound can be larger than
+<number> bytes.
No description for Walloca.
+ if (warn_alloca)
+ warning_at (loc, OPT_Walloca, "use of alloca");
+ continue;
Since alloca is a source code entity, it would be good to quote it using %< %>
(this hints translators to not translate it).
+ const char *alloca_str
+ = is_vla ? "variable-length array" : "alloca";
+ char buff[WIDE_INT_MAX_PRECISION / 4 + 4];
+ switch (w)
+ {
+ case ALLOCA_OK:
+ break;
+ case ALLOCA_BOUND_MAYBE_LARGE:
+ gcc_assert (assumed_limit != 0);
+ if (warning_at (loc, wcode,
+ "argument to %s may be too large", alloca_str))
+ {
+ print_decu (assumed_limit, buff);
+ inform (loc, "limit is '%u' bytes, but argument may be '%s'",
+ is_vla ? warn_vla_limit : warn_alloca_limit, buff);
+ }
+ break;
+ case ALLOCA_BOUND_DEFINITELY_LARGE:
+ gcc_assert (assumed_limit != 0);
+ if (warning_at (loc, wcode,
+ "argument to %s is too large", alloca_str))
+ {
+ print_decu (assumed_limit, buff);
+ inform (loc, "limit is %u' bytes, but argument is '%s'",
+ is_vla ? warn_vla_limit : warn_alloca_limit, buff);
+ }
+ break;
https://gcc.gnu.org/codingconventions.html#Diagnostics :
All diagnostics should be full sentences without English fragments substituted
in them, to facilitate translation.
Example:
if (warning_at (loc, wcode,
is_vla ? "argument to variable-length array may be too large"
: "argument to %<alloca%> may be too large"))
+ print_decu (assumed_limit, buff);
+ inform (loc, "limit is '%u' bytes, but argument may be '%s'",
+ is_vla ? warn_vla_limit : warn_alloca_limit, buff);
+ }
https://gcc.gnu.org/wiki/DiagnosticsGuidelines#Quoting :
Other elements such as numbers that do no refer to numeric constants that
appear in the source code should not be quoted.
+ warning_at (loc, wcode, "argument to %s may be too large due to "
+ "conversion from '%T' to '%T'",
+ alloca_str, invalid_casted_type, size_type_node);
From the same link:
Text should be quoted by either using the q modifier in a directive such as
%qE, or by enclosing the quoted text in a pair of %< and %> directives, and
never by using explicit quote characters. The directives handle the appropriate
quote characters for each language and apply the correct color or highlighting.
I don't think the above are critical problems, they could be fixed by a follow
up patch.
Cheers,
Manuel.
