On Fri, Jul 22, 2016 at 9:48 AM, Martin Jambor <mjam...@suse.cz> wrote: > On Thu, Jul 21, 2016 at 04:50:31PM +0000, Bin Cheng wrote: >> Hi, >> This patch adds new option -Wmissed-loop-optimizations warning on loops >> whose counter may overflow, as well as makes -Wunsafe-loop-optimizations an >> alias to the new option. >> Bootstrap and test on x86_64 ongoing. Is it OK? > > I'm repeating myself and since we already have a warning for this it > might make sense to continue having one, but shouldn't we be trying to > move towards the -fopt-info mechanism for optimization feedback? We > already seem to have OPTGROUP_LOOP even, so could you perhaps consider > also adding a call to > > dump_printf_loc (MSG_MISSED_OPTIMIZATION, loc, text) > > ? Hmm, in this way I will see if I can change this single patch and add warning message in opt-info category.
Thanks, bin > > Thanks, > > Martin >
