On 25 July 2016 at 18:18, ayush goel <ayushgoel1...@gmail.com> wrote: > On top of the previously filed patch for importing gnulib (the link > isn’t available on the archive yet, however this contains some of the > information: > http://gcc.1065356.n5.nabble.com/Importing-gnulib-into-the-gcc-tree-td1275807.html#a1279573) > now I have replaced another function from libiberty with the > corresponding version from gnulib. > Even though in both OSX and GNU/Linux, fnmatch is provided by the GNU > libc already, so the copy in libiberty is not used in your systems. > However since the objective is to replace whatever functions can be > leveraged by gnulib, these changes have been made.
Why the change from "fnmatch.h" to <fnmatch.h>? Also, are the files in gnulib and libiberty semantically identical? The wiki page does not say anything about this. How did you check this? GCC can run on other systems besides OSX and GNU/Linux, how can you test that your change does not break anything on those systems? Cheers, Manuel.
