On Tue, 26 Jul 2016, Prathamesh Kulkarni wrote:

> +     warning_at (gimple_location (g), OPT_Wunused_value,
> +                 "Call from %s to %s has no effect",
> +                 e->caller->name (), e->callee->name ());

Diagnostics should not start with capital letters.  Function names in 
diagnostics should be quoted, so %qs.  Also, what form is this name in?  
If it's the internal UTF-8 form, you need to use identifier_to_locale on 
it to produce something suitable for a diagnostic.  And for C++ you need 
to make sure the name is a proper pretty name (including classes / 
namespaces / type etc.) as produced by the decl_printable_name langhook, 
before passing it to identifier_to_locale.

-- 
Joseph S. Myers
jos...@codesourcery.com

Reply via email to