On 08/15/16 07:43, Martin Liška wrote:
All nits are applied in the second version of patch.
don't seem to match? Why 'e'?
I've renamed it to -x, well, a lot of letters are already occupied.
I guess 'x' may be better. If there is no good choice, do we really need a
short name? (There didn't seem to be a good letter available. I'm ambivalent so
will leave it to you.)
gcc/doc/gcov.texi
+For situations when a long name can potentially hit filesystem path limit,
+let's calculate md5sum of the path and create file
Sorry I missed this first time round. The language is straight from the comment
you added, so not really suitable for user documentation. Add a bit of
backstory. How about:
"By default, gcov uses the full pathname of the source files to to create an
output filename. This can lead to long filenames that can overflow filesystem
limits. This option creates names of the form
@file{@var{source-file}##@var{md5}.gcov}, where the @var{source-file} component
is the final filename part and the @var{md5} component is calculated from the
full mangled name that would have been used otherwise."
+ const char *opts = "abcdfhilmno:s:pruvx";
Could you fix the alphabetization while you're there? (s:pr)
+ /* With -x flag, file names will be in format:
+ source_file.c##<md5sum>.gcov. */
comment shouldn't really mention the option name. Use some indirection to avoid
another place that could get inconsistent :)
/* When hashing filenames, we shorten them by only using the filename
component and appending a hash of the full (mangled) pathname. */
nathan
