On Wed, Aug 31, 2011 at 1:02 PM, Artem Shinkarov <artyom.shinkar...@gmail.com> wrote: > Here is a newer version of the patch, which transforms the builtin to > the VEC_SHUFFLE_EXPR in the front-end. > > Several comments: > 1) Helper function for the pseudo-builtins. > In my case the builtin can have 2 or 3 arguments, and I think that I > expressed that in a pretty much short way without any helper function. > Am I missing something? > > 2) Richard, why do you want to treat VEC_SHUFFLE_EXPR as > GIMPLE_TERNARY_RHS when VEC_COND_EXPR (which is about the same as > VEC_SHUFF_EXPR) is single_rhs? From my perspective I don't see much of > a difference whether it is trenary or single, so I converted it to > trenary as you asked. But still it looks suspicious that vec_cond and > vec_shuffle are treated differently.
VEC_SHUFFLE_EXPR has three operands, VEC_COND_EXPR is a little weird, as it has a sub-expression - if you count that as a single operand then it would have three too. I'll consider converting it to ternary, too. Richard. > Can anyone review the x86 parts? > > > Thanks, > Artem. >
