Hi Jeff, > > The following patch reverts to the old behaviour. I also removed misleading > > comments and related logic that checks for the cached result. There might > > be > > other procedures with similar inconsistency but here I only modified the > offending ones. > Thanks. Given how much cut-n-paste we do with the tcl code there's a > good chance this problem exists elsewhere. I don't start ranting about > tcl/dejagnu, I'll just put me in a terrible mood for the rest of the day.
Indeed. > > Alternatively, it would be possible to switch to the new method and do the > caching > > but it is more intrusive change that requires careful analysis of the > > results > > and the tests will not likely be directly comparable with old results > (because of > > flag mixing into the test names). It's safer to restore the original > behaviour > > as the patch was not supposed to change any existing results. > I'd go with the safer approach for now -- I keep holding out hope that > there's a silver bullet out there that will allow us to replace dejagnu > and all its tcl goop some day. I noticed over time that tcl/dejagnu have a unique set of features. Replacing them with something else at some point wouldn't be a bad thing. > > > > > Ok to apply? > > > > Regards, > > Robert > > > > gcc/testsuite/ > > * lib/target-supports.exp > > (check_effective_target_vect_aligned_arrays): Don't cache the result. > > (check_effective_target_vect_natural_alignment): Ditto. > > (check_effective_target_vector_alignment_reachable): Ditto. > > (check_effective_target_vector_alignment_reachable_for_64bit): Ditto. > OK. > jeff > > Committed as r239730. Regards, Robert
