gcc-patches-ow...@gcc.gnu.org wrote on 24/08/2011 02:20:50 PM: > > This avoids the file/location clutter in front of each line > in the vectorizer dump. While this is useful for people > requesting -fvectorizer-verbose=N in dump files this makes > you unable to compare dumps for testcases on a branch and trunk. > It also makes lines excessively long because the testsuite > filename paths are so long. Very annoying. > > (I'd argue also that -fvectorizer-verbose=N dumps to the dump > file if available and not always to stderr is bogus, but well ...) > > This patch has made my life a lot easier debugging the data dependence > stuff. > > Bootstrapped and tested on x86_64-unknown-linux-gnu, installed on trunk. > > Richard. > > 2011-08-24 Richard Guenther <rguent...@suse.de> > > * tree-vectorizer.c (vect_print_dump_info): Avoid the > file and location clutter when dumping to dump files.
IMO it's a bad idea. It's now impossible to find anything when compiling a big file. How about only removing the file name? Index: tree-vectorizer.c =================================================================== --- tree-vectorizer.c (revision 178374) +++ tree-vectorizer.c (working copy) @@ -149,16 +149,12 @@ vect_print_dump_info (enum vect_verbosit if (!current_function_decl || !vect_dump) return false; - if (dump_file) - fprintf (vect_dump, "\n"); - - else if (vect_location == UNKNOWN_LOC) - fprintf (vect_dump, "\n%s:%d: note: ", - DECL_SOURCE_FILE (current_function_decl), + if (vect_location == UNKNOWN_LOC) + fprintf (vect_dump, "\nline %d: ", DECL_SOURCE_LINE (current_function_decl)); else - fprintf (vect_dump, "\n%s:%d: note: ", - LOC_FILE (vect_location), LOC_LINE (vect_location)); + fprintf (vect_dump, "\nline %d: ", + LOC_LINE (vect_location)); return true; } Ira > > Index: gcc/tree-vectorizer.c > =================================================================== > --- gcc/tree-vectorizer.c (revision 178028) > +++ gcc/tree-vectorizer.c (working copy) > @@ -149,7 +149,10 @@ vect_print_dump_info (enum vect_verbosit > if (!current_function_decl || !vect_dump) > return false; > > - if (vect_location == UNKNOWN_LOC) > + if (dump_file) > + fprintf (vect_dump, "\n"); > + > + else if (vect_location == UNKNOWN_LOC) > fprintf (vect_dump, "\n%s:%d: note: ", > DECL_SOURCE_FILE (current_function_decl), > DECL_SOURCE_LINE (current_function_decl)); >