On Sat, Aug 27, 2016 at 9:50 PM, Paul Richard Thomas <paul.richard.tho...@gmail.com> wrote: > Although we have said that we would commit on Monday if no review is > forthcoming, we would very much prefer that somebody takes a look. We > understand perfectly that a 4052 line patch is rather daunting. > However, even a cursory scan of the patch would be helpful.
To be honest, I had a nagging suspicion that DTIO would remain forever on the TODO list, but as you and Jerry have pulled it off, my hat is off to you! Anyway, a small nit I found was the function st_set_nml_var in libgfortran. This is an exported function, and thus part of the ABI. So you cannot add arguments to it, as that would break backwards compatibility. I suggest you make a new function (say, st_set_nml_var2, or whatever), and make the old one a simple wrapper that calls the new one with the additional arguments set to null. (Unfortunately I haven't looked thoroughly at the entire patch, so I cannot say this is a complete review. Sorry!) (Trying to send again as my previous message was caught by the mailing list spam filters. Lets see if this one is more successful). -- Janne Blomqvist
