On Sep 6, 2016, at 11:13 AM, Szabolcs Nagy <szabolcs.n...@arm.com> wrote: > > On 06/09/16 18:34, Mike Stump wrote: >> On Sep 6, 2016, at 2:11 AM, Torvald Riegel <trie...@redhat.com> wrote: >>> >>> On Wed, 2016-08-24 at 20:08 +0100, Szabolcs Nagy wrote: >>>> Pass build time CC make var down to dejagnu so the sysroot >>>> is set correctly when gcc is built with --with-build-sysroot. >>>> >>>> libitm/ >>>> 2016-08-24 Szabolcs Nagy <szabolcs.n...@arm.com> >>>> >>>> PR testsuite/71931 >>>> * configure.ac: Add AC_CONFIG_FILES. >>>> * configure: Regenerated. >>>> * testuite/Makefile.am: Add rule for libitm-test-support.exp. >>>> * testuite/Makefile.in: Regenerated. >>>> * testuite/libitm-test-support.exp.in: New. >>>> * testuite/lib/libitm.exp (libitm_init): Use BUILD_CC. >>>> >>> >>> I don't know enough about the build system to really review this. If a >>> similar patch has been ACKed and applied for libatomic (71931 states >>> that both are affected), then I guess this is OK? >> >> I was hoping that someone else might review it, but i can see why no one >> else can or wants to. >> >> Sorry for the feet dragging, Ok. If libatomic has the same problem, and a >> similar solutions works there, Ok to fix it as well. >> > > the libatomic changes were not accepted: > https://gcc.gnu.org/ml/gcc-patches/2016-08/msg01771.html > > i'll try a bit different approach > (using automake's EXTRA_DEJAGNU_SITE_CONFIG so the > CC setting is only done in the in-tree site.exp)
Oh, yeah. Sorry, I did see that but didn't mean to ignore the concern raised. Please do work out install v non-install testing before it goes in.
