On Thu, 8 Sep 2016, Martin Sebor wrote:
> diff --git a/gcc/doc/tm.texi.in b/gcc/doc/tm.texi.in
> index da133a4..4607495 100644
> --- a/gcc/doc/tm.texi.in
> +++ b/gcc/doc/tm.texi.in
> @@ -4081,6 +4081,13 @@ In either case, it remains possible to select
> code-generation for the alternate
> scheme, by means of compiler command line switches.
> @end defmac
>
> +@deftypefn {Target Hook} {const char *} TARGET_LIBC_PRINTF_POINTER_FORMAT
> (tree, const char **@var{flags})
> +A hook to determine the target @code{printf} implementation format string
> +that the most closely corresponds to the @code{%p} format directive.
> +The object pointed to by the @var{flags} is set to a string consisting
> +of recognized format flags such as the @code{'#'} character.
> +@end deftypefn
No, the substance of hook documentation should go in target.def with just
an @hook line in tm.texi.in leading to the documentation going in tm.texi
automatically.
You appear to be defining a target macro masquerading as a hook. Please
don't (new target macros should be avoided where possible); use a proper
hook. (Maybe the settings depending on OS rather than architecture means
it needs to be one of those whose default is a manual setting in
target-def.h rather than automatically generated, but that should be the
limit of deviation from the normal workings of hooks.)
> + const char *pfmt = TARGET_LIBC_PRINTF_POINTER_FORMAT (arg, &flags);
With a proper hook them you'd call targetm.libc_printf_pointer_format.
> + inform (callloc,
> + (nbytes + exact == 1
> + ? "format output %wu byte into a destination of size %wu"
> + : "format output %wu bytes into a destination of size %wu"),
> + nbytes + exact, info.objsize);
You need to use G_() around both format strings in such a case; xgettext
doesn't know how to extract them both.
--
Joseph S. Myers
jos...@codesourcery.com
