On Thu, Sep 22, 2016 at 10:05:46PM +0200, Jakub Jelinek wrote: > This is something I've been unhappy for a long time with, and finally got to > write something for it.
> When some test expects more than one error or warning or message on the same > source line, people have to use absolute line number on the dg-* directives > that is not on the right line, as DejaGNU handles just . (current line, the > default if the directive doesn't have all the arguments), 0 (no expected > line) and <number> for absolute line number. Great! But could this patch be responsible with some dg-error related test errors on s390x that are present with current HEAD? E.g. (Sorry for the linebreaks that vim has inserted). -- spawn -ignore SIGHUP /home/vogt/src/gcc/build-master/gcc/xgcc -B/home/vogt/src/\ gcc/build-master/gcc/ /home/vogt/src/gcc/gcc/testsuite/gcc.target/s390/hotpatch\ -compile-1.c -fno-diagnostics-show-caret -fdiagnostics-color=never -O3 -mzarch \ -mhotpatch=-1,0 -S -m64 -o hotpatch-compile-1.s^M cc1: error: arguments to '-mhotpatch=n,m' should be non-negative integers^M compiler exited with status 1 output is: cc1: error: arguments to '-mhotpatch=n,m' should be non-negative integers^M FAIL: gcc.target/s390/hotpatch-compile-1.c (test for errors, line 1) FAIL: gcc.target/s390/hotpatch-compile-1.c (test for excess errors) Excess errors: cc1: error: arguments to '-mhotpatch=n,m' should be non-negative integers -- So, the test expects an error: /* { dg-error "arguments to .-mhotpatch=n,m. should be non-negative integers" "" { target *-*-* } 1 } */ but no longer matches the error that really occurs? Ciao Dominik ^_^ ^_^ -- Dominik Vogt IBM Germany