On 09/27/2016 03:05 PM, Richard Biener wrote: > On Tue, Sep 27, 2016 at 2:57 PM, Nathan Sidwell <nat...@acm.org> wrote: >> On 09/27/16 08:46, Martin Liška wrote: >> >>>> Second version of the patch adds validation to gcov.exp, where $result is >>>> scanned for "File '<built-in>'". >>>> Luckily current test-case hit that verification: >>>> >>>> FAIL: gcc.misc-tests/gcov-6.c gcov failed: <built-in>.gcov should not be >>>> created >>>> FAIL: gcc.misc-tests/gcov-7.c gcov failed: <built-in>.gcov should not be >>>> created >> >> >> thanks. >> >>>>> One thing I dislike is negated predicates though -- I think I'd find >>>>> if (!gimple_has_reserved_location (gs)) >>>>> to be more understandable (particularly as that matches the sense of >>>>> RESERVED_LOCATION_P. >>>> >>>> >>>> Agree with you, renamed to gimple_has_reserved_location. >>>> Ready with that change? >> >> >>> Adding missing patch. >> >> >> I think this needs Richard's approval for the gimple predicates etc. But OK >> for me. > > Sorry for not chiming in earlier but I'd rather have you use > > if (RESERVED_LOCATION_P (gimple_location (...))) > > and not add the gimple_has_not_reserved_location wrapper. That's more in line > with the other uses you have. > > Ok with that change (well, adding the RESERVED_LOCATION_P macro is ok). > > Richard.
Done that in r240536. Thanks for the review. Martin > >> nathan
