On 30/09/16 10:31, Matthew Wahab wrote:
The recently added tests gcc.target/arm/aapcs-{3,4}.c are intended
to check the behaviour of th ARM Alternative FP16 format. They both
check for compiler support of FP16 using dg-require-effective-target
arm_fp16_ok This is too weak since the directive is true when
fp16-format=ieee is set, as it is when the +fp16 extension is
enabled.

This patch changes the directives for both tests to
  dg-require-effective-target arm_fp16_alternative_ok
which is only enabled with fp16-format=alternative is set.

For fp16-aapcs-4.c, it was also necessary to add the
-mfp16-format=alternative to the dg-options, rather than use the
arm_fp16-alternative add-options. There seems to some interaction
between the different directives and the dg-skip-if, but I can't track
it down.

Tested for cross-compiled arm-none-eabi by running the
gcc.target/arm/arm.exp testsuite on an ARMv8.2-A emulator and on an
ARMv8-A emulator.

Ok for trunk?

Ok.
Thanks,
Kyrill

Matthew

testsuite/
2016-09-28  Matthew Wawhab  <matthew.wa...@arm.com>

    * gcc.target/arm/fp16-aapcs-3.c: Replace the arm_fp16_ok with
    arm_fp16_alternative_ok as the required effective target.
    * gcc.target/arm/fp16-aapcs-4.c: Likewise.  Also add
    -mfp16-format=alternative to the dg-options directive and remove
    the dg-add-otions directive.

Reply via email to