On 09/25/2016 03:13 AM, Bernd Edlinger wrote:
Hi!Currently CHECKING_P is not a boolean flag but a ternary option. However the _P in the name implies it is a boolean. That should be cleaned up again IMHO. So this patch splits CHECKING_P into CHECKING_P and a new flag ENABLE_EXTRA_CHECKING. All uses of CHECKING_P are actually of the form "if (CHECKING_P)" so there is no problem there, only the flag_checking is tested at one place for > 1, thus we have to make sure that the default initial value of flag_checking is 0, 1 or 2, dependent on CHECKING_P and ENABLE_EXTRA_CHECKING. Bootstrapped and reg-tested on x86_64-pc-linux-gnu. Is it OK for trunk? Thanks Bernd. changelog-checking-p.txt 2016-09-25 Bernd Edlinger <bernd.edlin...@hotmail.de> * configure.ac: Split CHECKING_P into CHECKING_P and ENABLE_EXTRA_CHECKING. * configure: Regenerated. * config.in: Adjust commment of CHECKING_P. Add ENABLE_EXTRA_CHECKING. * common.opt (flag_checking): Use CHECKING_P and ENABLE_EXTRA_CHECKING.
OK. jeff
