On Wed, Oct 05, 2016 at 06:18:50PM -0400, Michael Meissner wrote:
> I have removed the #define of __float128, and instead created a keyword that
> points to the _Float128 type. I added a little commentary on the use of
> __ieee128 (which is needed to create the type when we aren't using
> __float128).
>
> I did a bootstrap and test on a little endian power8 system with no
> regressions. Can I install the patch on the trunk?
Not easy to read this patch :-)
It looks good; it is fine for trunk if Joseph thinks it is good, too.
One nit...
> --- gcc/testsuite/gcc.target/powerpc/float128-type-1.c
> (.../svn+ssh://meiss...@gcc.gnu.org/svn/gcc/trunk/gcc/testsuite/gcc.target/powerpc)
> (revision 0)
> +++ gcc/testsuite/gcc.target/powerpc/float128-type-1.c
> (.../gcc/testsuite/gcc.target/powerpc) (revision 240807)
> @@ -0,0 +1,24 @@
> +/* { dg-do compile { target { powerpc64*-*-linux* && lp64 } } } */
> +/* { dg-require-effective-target powerpc_vsx_ok } */
> +/* { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } {
> "-mcpu=power8" } } */
> +/* { dg-options "-mcpu=power8 -O2" } */
> +
> +/* -mfloat128-type is enabled by default on VSX Linux 64-bit systems. */
"Check that" etc.? Also for the next testcase. It is really helpful
five or ten years later if a testcase bluntly says what it is testing
for so you don't have to reverse engineer that :-)
Thanks,
Segher
