Bernd Schmidt <bschm...@redhat.com> writes: > On 10/18/2016 10:30 PM, David Malcolm wrote: >> >> I'm not in love with the names I chose in this patch. It does seem odd >> having an "rtx_reader" class that can't actually read hierarchical rtx. >> >> How about "md_reader" as the base class (with responsibility for the >> things in read-md.o), and "rtx_reader" for the subclass (adding the >> things in read-rtl.o)? > > I think a lot of renaming was for a variable (base_rtx_reader_ptr), not > the class, wasn't it? I would very much like to avoid these, but I think > for the class names it should be ok to go with what you suggest.
FWIW, using md_reader and rtx_reader sounds good to me too. These days .md files contain more than just rtl (although everything retains the same lispy syntax), so the names seem pretty natural. Thanks, Richard