On Fri, Oct 21, 2016 at 12:56 PM, Ximin Luo <infini...@pwned.gg> wrote: > Richard Biener: >> On Tue, Oct 18, 2016 at 2:35 PM, Ximin Luo <infini...@pwned.gg> wrote: >>> >>> Thanks, I'll add the Changelog entry. My computer isn't very powerful, so I >>> didn't bootstrap it yet, I only tested it on a stage1 compiler, on Debian >>> testing/unstable. I'll find some time to bootstrap it and test it fully >>> over the next few days. >>> >>> Shall I also get rid of the Darwin force_at_comp_dir stuff? Looking into it >>> a bit more, my patch basically obsoletes the need for this so I can delete >>> that as well. >> >> That would be nice. >> > > Hi, > > Attached is the ChangeLog plus updated patch, rebased against the 2016-10-16 > snapshot. Also I noticed I got the wrong bug number, the correct one is 77985 > not 77895. > > I've tested it on a Debian testing/unstable x86_64-linux-gnu system. The > results are good, the same tests fail both before and after the patch, and we > have 2 new expected successes. Unfortunately I don't have access (and am > unlikely to get access) to a Darwin system to test it on. > > Snippets of the test logs are attached. The full logs are about 200MB each in > size (4MB XZ-compressed, each) so I guessed I shouldn't send them via > email... The snippets were grepped from the logs using the '^FAIL: \|^# > of\|pr77985' pattern. You can diff them to check that the results are same in > both cases.
The patch is ok. Do you have commit privileges? Thanks, Richard. > X > > -- > GPG: ed25519/56034877E1F87C35 > GPG: rsa4096/1318EFAC5FBBDBCE > https://github.com/infinity0/pubkeys.git