On 09/08/2011 06:32 AM, Dodji Seketeli wrote:
I have a question about this.  It seems to me that adding the whitespace
there improves the consistency of the code base, and I thought that it
was allowed to make those changes if there are tangent to other
meaningful changes done in that area.  If even that is not allowed, then
does that mean that such whitespace nits in the code base can never be
fixed?  I am not willing to argue over that change, I am just trying to
understand.

I usually only fix whitespace issues when I'm already changing something else on that line; I like to keep a patch specific to what it's actually fixing. For other whitespace issues I'd put them in a separate patch.

But other people may feel differently about this question.

Jason

Reply via email to