Hi Mike,

> I have built the spec 2006 CPU benchmark suite with these changes, and the
> power8 (ISA 2.07) code generation does not change.

Very good to hear :-)

Just some nits; okay for trunk with that fixed:

> +(define_split
> +  [(set (match_operand:EXTHI 0 "altivec_register_operand" "")
> +     (sign_extend:EXTHI
> +      (match_operand:HI 1 "indexed_or_indirect_operand" "")))]
> +  "TARGET_P9_VECTOR && reload_completed"
> +  [(set (match_dup 2)
> +     (match_dup 1))
> +   (set (match_dup 0)
> +     (sign_extend:EXTHI (match_dup 2)))]
> +{
> +  operands[2] = gen_rtx_REG (HImode, REGNO (operands[1]));
> +})

Please lose the default "" (here and elsewhere).

> Property changes on: gcc/testsuite/gcc.target/powerpc/p9-minmax-1.c
> ___________________________________________________________________
> Modified: svn:mergeinfo
>    Merged /trunk/gcc/testsuite/gcc.target/powerpc/p9-minmax-1.c:r241733-241924
> 
> 
> Property changes on: gcc/testsuite/gcc.target/powerpc/p9-minmax-2.c
> ___________________________________________________________________
> Modified: svn:mergeinfo
>    Merged /trunk/gcc/testsuite/gcc.target/powerpc/p9-minmax-2.c:r241733-241924

I don't know what this is?

Thanks!


Segher

Reply via email to