On 11/23/2016 08:30 PM, Jeff Law wrote:
On 11/23/2016 12:00 PM, Bernd Schmidt wrote:
Note that I misspelled the PR number in the 0/3 message :-/
On 11/23/2016 07:57 PM, Bernd Schmidt wrote:
1. I noticed comparisons between set_src_cost and set_rtx_cost seemed to
be invalid. There seems to be no good reason that insn_rtx_cost
shouldn't use the latter. It also makes the numbers comparable to the
ones you get from seq_cost.
Bernd
71280-1.diff
PR rtl-optimization/78120
* rtlanal.c (insn_rtx_cost): Use set_rtx_cost.
LGTM. As a principle, if we have the full set, we ought to use
set_rtx_cost, and only use set_src_cost if we don't have the full set
expression.
Note that this cannot really be applied on its own, it needs patch 2/3
so as to not make the x86 port do strange things. So I'll be holding off
on this one until we have a consensus on the whole set.
Bernd
