I'm sorry for delay.

I have a problem with the patch:
(Stripping trailing CRs from patch; use --binary to disable.)
patching file avr-arch.h
(Stripping trailing CRs from patch; use --binary to disable.)
patching file avr-devices.c
(Stripping trailing CRs from patch; use --binary to disable.)
patching file avr-mcus.def
Hunk #1 FAILED at 62.
1 out of 1 hunk FAILED -- saving rejects to file avr-mcus.def.rej
(Stripping trailing CRs from patch; use --binary to disable.)
patching file gen-avr-mmcu-specs.c
Hunk #1 succeeded at 215 (offset 5 lines).
(Stripping trailing CRs from patch; use --binary to disable.)
patching file specs.h
Hunk #1 succeeded at 58 (offset 1 line).
Hunk #2 succeeded at 66 (offset 1 line).

2016-11-22 23:27 GMT+03:00 Georg-Johann Lay <a...@gjlay.de>:
> Denis Chertykov schrieb:
>>
>> Do you have any objections, George ?
>
>
> No, the last delta rev3 from 2016-11-10 looks fine to me.
>
>
>>
>> 2016-11-22 8:05 GMT+03:00 Pitchumani Sivanupandi
>> <pitchumani.sivanupa...@microchip.com>:
>>>
>>> Ping!
>>>
>>> On Monday 14 November 2016 07:03 PM, Pitchumani Sivanupandi wrote:
>>>>
>>>> Ping!
>>>>
>>>> On Thursday 10 November 2016 01:53 PM, Pitchumani Sivanupandi wrote:
>>>>>
>>>>> On Wednesday 09 November 2016 08:05 PM, Georg-Johann Lay wrote:
>>>>>>
>>>>>> On 09.11.2016 10:14, Pitchumani Sivanupandi wrote:
>>>>>>>
>>>>>>> On Tuesday 08 November 2016 02:57 PM, Georg-Johann Lay wrote:
>>>>>>>>
>>>>>>>> On 08.11.2016 08:08, Pitchumani Sivanupandi wrote:
>>>>>>>>>
>>>>>>>>> I have updated patch to include the flash size as well. Took that
>>>>>>>>> info from
>>>>>>>>> device headers (it was fed into crt's device information note
>>>>>>>>> section
>>>>>>>>> also).
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> The new option would render -mn-flash superfluous, but we should
>>>>>>>>>> keep it for
>>>>>>>>>> backward compatibility.
>>>>>>>>>
>>>>>>>>> Ok.
>>>>>>>>>>
>>>>>>>>>> Shouldn't link_pmem_wrap then be removed from link_relax, i.e.
>>>>>>>>>> from
>>>>>>>>>> LINK_RELAX_SPEC?  And what happens if relaxation is off?
>>>>>>>>>
>>>>>>>>> Yes. Removed link_pmem_wrap from link_relax.
>>>>>>>>> Disabling relaxation doesn't change -mpmem-wrap-around behavior.
>>>>>>>>> ....
>>>>>>>>> flashsize-and-wrap-around.patch
>>>>>>>>
>>>>>>>>
>>>>>>>>> diff --git a/gcc/config/avr/avr-mcus.def
>>>>>>>>> b/gcc/config/avr/avr-mcus.def
>>>>>>>>> index 6bcc6ff..9d4aa1a 100644
>>>>>>>>
>>>>>>>>
>>>>>>>>>  /*
>>>>>>>>
>>>>>>>> ....
>>>>>>>
>>>>>>>  /* Classic, > 8K, <= 64K.  */
>>>>>>> -AVR_MCU ("avr3",             ARCH_AVR3, AVR_ISA_NONE, NULL,
>>>>>>> 0x0060, 0x0, 1)
>>>>>>> -AVR_MCU ("at43usb355",       ARCH_AVR3, AVR_ISA_NONE,
>>>>>>> "__AVR_AT43USB355__",        0x0060, 0x0, 1)
>>>>>>> -AVR_MCU ("at76c711",         ARCH_AVR3, AVR_ISA_NONE,
>>>>>>> "__AVR_AT76C711__",          0x0060, 0x0, 1)
>>>>>>> +AVR_MCU ("avr3",             ARCH_AVR3, AVR_ISA_NONE, NULL,
>>>>>>> 0x0060, 0x0, 1, 0x6000)
>>>>>>> +AVR_MCU ("at43usb355",       ARCH_AVR3, AVR_ISA_NONE,
>>>>>>> "__AVR_AT43USB355__",        0x0060, 0x0, 1, 0x6000)
>>>>>>> +AVR_MCU ("at76c711",         ARCH_AVR3, AVR_ISA_NONE,
>>>>>>> "__AVR_AT76C711__",          0x0060, 0x0, 1, 0x4000)
>>>>>>> +AVR_MCU ("at43usb320",       ARCH_AVR3, AVR_ISA_NONE,
>>>>>>> "__AVR_AT43USB320__",        0x0060, 0x0, 1, 0x10000)
>>>>>>>  /* Classic, == 128K.  */
>>>>>>> -AVR_MCU ("avr31",            ARCH_AVR31, AVR_ERRATA_SKIP, NULL,
>>>>>>> 0x0060, 0x0, 2)
>>>>>>> -AVR_MCU ("atmega103",        ARCH_AVR31, AVR_ERRATA_SKIP,
>>>>>>> "__AVR_ATmega103__",     0x0060, 0x0, 2)
>>>>>>> -AVR_MCU ("at43usb320",       ARCH_AVR31, AVR_ISA_NONE,
>>>>>>> "__AVR_AT43USB320__",       0x0060, 0x0, 2)
>>>>>>> +AVR_MCU ("avr31",            ARCH_AVR31, AVR_ERRATA_SKIP, NULL,
>>>>>>> 0x0060, 0x0, 2, 0x20000)
>>>>>>> +AVR_MCU ("atmega103",        ARCH_AVR31, AVR_ERRATA_SKIP,
>>>>>>> "__AVR_ATmega103__",     0x0060, 0x0, 2, 0x20000)
>>>>>>>  /* Classic + MOVW + JMP/CALL.  */
>>>>>>
>>>>>>
>>>>>> If at43usb320 is in the wrong multilib, then this should be handled as
>>>>>> separate issue / patch together with its own PR. Sorry for the
>>>>>> confusion.  I
>>>>>> just noticed that some fields don't match...
>>>>>>
>>>>>> It is not even clear to me from the data sheet if avr3 is the correct
>>>>>> multilib or perhaps avr35 (if it supports MOVW) or even avr5 (if it
>>>>>> also has
>>>>>> MUL) as there is no reference to the exact instruction set -- Atmochip
>>>>>> will
>>>>>> know.
>>>>>>
>>>>>> Moreover, such a change should be sync'ed with avr-libc as all
>>>>>> multilib
>>>>>> stuff is hand-wired there: no use of --print-foo meta information
>>>>>> retrieval
>>>>>> by avr-libc :-((
>>>>>>
>>>>>> I filed PR78275 and https://savannah.nongnu.org/bugs/index.php?49565
>>>>>> for
>>>>>> this one.
>>>>>>
>>>>> Thats better. I've attached the updated patch. If OK, could someone
>>>>> commit please?
>>>>>
>>>>> I'll try if I could find some more info for AT43USB320.
>>>>>
>>>>> Regards,
>>>>> Pitchumani
>>>>>
>>
>

Reply via email to