[Ping] [C++ Patch] PR 78637 ("ICE on invalid C++ code (internal compiler error: in pop_namespace, at cp/name-lookup.c:3826)")

[Paolo Carlini]

Hi,

gently pinging, might be rather straightforward...

On 02/12/2016 15:20, Paolo Carlini wrote:

Hi,

this regression is caused by my fix for c++/60385, where I changed push_namespace to early return (a bool) when pushdecl fails. In the present testcase, a different push_namespace call in cp_parser_namespace_definition, for nested namespace definitions, fails, thus returns early, and that is inconsistent with the final loop (pop_namespace ICEs):

  /* Finish the nested namespace definitions.  */
  while (nested_definition_count--)
    pop_namespace ();

To fix this problem, I think we can simply increment nested_definition_count only when push_namespace succeeds. Tested x86_64-linux.

Thanks,
Paolo.