Hi: I get the copyright assignment, it's ok for commit. but recently, The gcc mainline trunk are fail to building on mips64el-unknown-linux, the bug https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78660 show the problem.
Thanks, Paul On Thu, Nov 17, 2016 at 7:14 PM, Matthew Fortune <matthew.fort...@imgtec.com> wrote: > Hi Jeff, > > Am I OK to accept this change without copyright assignment from Paul? > > The change is small and there is no other way it could be implemented > anyway if I had someone write it from scratch. > > Thanks, > Matthew > >> -----Original Message----- >> From: Paul Hua [mailto:paul.hua...@gmail.com] >> Sent: 17 November 2016 03:01 >> To: Matthew Fortune >> Cc: gcc-patches@gcc.gnu.org; catherine_mo...@mentor.com >> Subject: Re: [PATCH,gcc/MIPS] Make loongson3a use fused madd.d >> >> ping... >> >> On Thu, Nov 3, 2016 at 7:58 PM, Paul Hua <paul.hua...@gmail.com> wrote: >> > Hi Matthew, >> > >> > Thanks for your comments, update the patch. >> > >> > *** gcc/ChangeLog *** >> > >> > 2016-11-03 Chenghua Xu <paul.hua...@gmail.com> >> > >> > * config/mips/mips.h (ISA_HAS_FUSED_MADD4): Enable for >> > TARGET_LOONGSON_3A. >> > (ISA_HAS_UNFUSED_MADD4): Exclude TARGET_LOONGSON_3A. >> > >> > Thanks, >> > Paul >> > >> > On Thu, Nov 3, 2016 at 6:31 PM, Matthew Fortune >> > <matthew.fort...@imgtec.com> wrote: >> >> Paul Hua <paul.hua...@gmail.com> writes: >> >>> Loongson3a has 4 operand fused madd instrcution. This patch set >> >>> loongson3a use fused madd.d. >> >> >> >> Hi Paul, >> >> >> >> Thanks for the fix. I was vaguely aware that this was wrong for >> >> loongson-3a but never confirmed it. >> >> >> >> I suspect this change is mechanical enough that it can bypass >> >> copyright assignment but I'd need a global maintainer to comment. >> >> >> >> I've sent you copyright assignment paperwork separately. >> >> >> >> Two comments on the patch: >> >> >> >>> ChangeLog : >> >>> >> >>> *** gcc/ChangeLog *** >> >>> >> >>> 2016-11-03 Chenghua Xu <paul.hua...@gmail.com> >> >>> >> >>> config/mips/ >> >>> * mips.h: Set loongson3a use fused madd.d. >> >> >> >> The changelog needs to reference what was changed rather than the >> >> effect of the change: >> >> >> >> * config/mips/mips.h (ISA_HAS_FUSED_MADD4): Enable for >> >> TARGET_LOONGSON_3A. >> >> (ISA_HAS_UNFUSED_MADD4): Exclude TARGET_LOONGSON_3A. >> >> >> >> >> >>>diff --git a/gcc/config/mips/mips.h b/gcc/config/mips/mips.h index >> >>>81862a9..5076a2b 100644 >> >>>--- a/gcc/config/mips/mips.h >> >>>+++ b/gcc/config/mips/mips.h >> >>>@@ -1056,11 +1056,11 @@ struct mips_cpu_info { >> >>> >> >>> /* ISA has 4 operand fused madd instructions of the form >> >>> 'd = [+-] (a * b [+-] c)'. */ >> >>>-#define ISA_HAS_FUSED_MADD4 TARGET_MIPS8000 >> >>>+#define ISA_HAS_FUSED_MADD4 (TARGET_MIPS8000 || >> TARGET_LOONGSON_3A) >> >>> >> >>> /* ISA has 4 operand unfused madd instructions of the form >> >>> 'd = [+-] (a * b [+-] c)'. */ >> >>>-#define ISA_HAS_UNFUSED_MADD4 (ISA_HAS_FP4 && !TARGET_MIPS8000) >> >>>+#define ISA_HAS_UNFUSED_MADD4 (ISA_HAS_FP4 && !TARGET_MIPS8000 && >> >>>+!TARGET_LOONGSON_3A) >> >> >> >> Please split this line and move && !TARGET_LOONGSON_3A to the next >> >> line under ISA_HAS_FP4. >> >> >> >>> >> >>> /* ISA has 3 operand r6 fused madd instructions of the form >> >>> 'c = c [+-] (a * b)'. */ >> >> >> >> Thanks, >> >> Matthew >> >>