On 09.01.2017 21:43, Jakub Jelinek wrote: > Hi! > > On Fri, Jan 06, 2017 at 01:48:26PM +0100, Jakub Jelinek wrote: >> Yet another option is introduce AC_ARG_ENABLE into all those configure >> scripts (some macro in config/*.m4) and do the sed conditionally. > > Here is a patch to do that. > Bootstrapped/regtested on x86_64-linux (without > --with-gcc-major-version-only) and on i686-linux (with > --with-gcc-major-version-only), then tested make install of both. > The former uses the standard gcc -dumpversion of 7.0.0 and 7.0.0 in > pathnames (e.g. usr/local/bin/x86_64-pc-linux-gnu-gcc-7.0.0, > usr/local/lib/gcc/x86_64-pc-linux-gnu/7.0.0, > usr/local/libexec/gcc/x86_64-pc-linux-gnu/7.0.0, > usr/local/lib/go/7.0.0/x86_64-pc-linux-gnu, > usr/local/include/c++/7.0.0 etc.), while the latter uses > gcc -dumpversion of 7 and 7 in pathnames (e.g. > i686-pc-linux-gnu-gcc-7, usr/local/lib/gcc/i686-pc-linux-gnu/7, > usr/local/libexec/gcc/i686-pc-linux-gnu/7, > usr/local/lib/go/7/i686-pc-linux-gnu, > usr/local/include/c++/7 etc.). > Ok for trunk?
Thanks for working on this. I'm using such a layout for the Debian/Ubuntu GCC builds for some years. The one thing a dislike with your patch is the changed output of the -dumpversion option which is different whether you use the the new configure option or not. This could break builds of third party software. I would prefer having -dumpversion the very same output independent of any configure options. Please could you introduce a new option if you really need that? Matthias
