Ping?
On 01/06/2017 04:25 PM, Nathan Sidwell wrote:
This patch refactors the decl localizing that happens in
function_and_variable_visibility. It doesn't fix the bug I'm working on
(that's next).
Both the FOR_EACH_FUNCTION and FOR_EACH_VARIABLE loops contain very
similar, but not quite the same code for localizing a definition that
it's determined need not be externally visible. It looks to me that the
not-quite-the-sameness is erroneous, and this patch refactors that code
into a common subroutine. If the differences need to be maintained
(slight differences in when unique_name is updated and whether
resolution is set to LDPR_PREVAILING_DEF_IRONLY), I think a flag to the
new function would be best, rather than keep the duplicated code.
booted & tested on x86_64-linux, ok?
nathan
--
Nathan Sidwell
