On 01/18/2017 01:35 AM, Dominik Vogt wrote: > On Tue, Jan 10, 2017 at 03:40:00PM +0100, Martin Liška wrote: >> On 01/10/2017 02:56 PM, Richard Biener wrote: >>> On Mon, Jan 9, 2017 at 4:05 PM, Martin Liška <mli...@suse.cz> wrote: >>>> Second part of the patch does sorting of final congruence classes, it's >>>> groups >>>> and items included in the groups according DECL_UID. >>>> >>>> Both patches can bootstrap together on ppc64le-redhat-linux and survive >>>> regression tests. >>>> >>>> Ready to be installed? >>> >>> Minor nit: >>> >>> + auto_vec <congruence_class_group *> classes; >>> + for (hash_table<congruence_class_hash>::iterator it = m_classes.begin (); >>> + it != m_classes.end (); ++it) >>> + classes.safe_push (*it); >>> >>> use quick_push and reserve_exact m_classes.elements () elements for >>> the classes vector before. >> >> Thanks for hint. >> >>> >>> + >>> + classes.qsort (sort_congruence_class_groups_by_decl_uid); >>> >>> Ok with that change. >> >> Installed as r244273. > > This patch has somehow broken the error line information in some > s390x test case: > > .../build/gcc/xgcc -B.../gcc/ > .../gcc/testsuite/gcc.target/s390/target-attribute/tattr-2.c -O3 -march=zEC12 > -mno-htm -S -m64 -o tattr-2.s > > ... > .../gcc/testsuite/gcc.target/s390/target-attribute/tattr-2.c: > In function ‘a0’: > ^^^^ > .../gcc/testsuite/gcc.target/s390/target-attribute/tattr-2.c:23:3: > ^^^^ > error: Builtin ‘__builtin_tend’ is not supported without -mhtm > (default with -march=zEC12 and higher).
Hello. As I've been reading when the warning is emitted (rtl expansion), I guess a pair of function was merged by IPA ICF and thus the location points to a different function. I can't reproduce the test-case due to missing __HTM__. Can you please provide pre-processed source file? Thanks, Martin > > But function a0 is actually in lines 37 to 43. It looks like the > message has used the same line number as the previous message. > > Ciao > > Dominik ^_^ ^_^ >
