Re: [PLUGIN] Fix PLUGIN_FINISH_TYPE

[Diego Novillo]

On 11-09-22 09:40 , Dodji Seketeli wrote:

Romain Geissler<romain.geiss...@gmail.com>  a écrit:

I tried to fix PLUGIN_FINISH_DECL as well to include typedefs in C++.

The followings does not currently trigger the PLUGIN_FINISH_DECL
(or not in all cases), but should them ?
  - function parameters (in the function prototype)
  - definition (with a function body) of a top-level function (while the exact
    same function definition enclosed in a class definition will trigger
    PLUGIN_FINISH_DECL)
  - label declaration
  - constants defined by enums
  - namespace

Indeed.  finish_decl is not called in those cases.  As to if the
PLUGIN_FINISH_DECL event should be emitted for those, I'd say yes, at
least if I believe what the description in plugin.def says:

     /* After finishing parsing a declaration. */
     DEFEVENT (PLUGIN_FINISH_DECL)

But I'd rather ask what the maintainers think about it.

Jason, Diego?

Yes, those events should trigger a PLUGIN_FINISH_DECL call.


Diego.