Hi James,

Thanks for reviewing the patch and comments.

>> I wonder whether the current modeling of:
>> (define_insn_reservation "thunderx2t99_asimd_load4_elts" 6
>> Actually benefits the schedule in a meaningful way, or if it just increases

Done. Removed the scheduler modeling for thunderx2t99_asimd_load*_mult and
thunderx2t99_asimd_load*_elts for ld3/ld4 and st3/st4 which are rarely used.

The automaton size has come down drastically without that and hopefully
should be okay.
============================================================
Automaton `thunderx2t99'
      184 NDFA states,            838 NDFA arcs
      184 DFA states,             838 DFA arcs
      184 minimal DFA states,     838 minimal DFA arcs
      360 all insns          8 insn equivalence classes
    0 locked states
 1016 transition comb vector els,  1472 trans table els: use simple vect
 1472 min delay table els, compression factor 4

Automaton `thunderx2t99_advsimd'
      453 NDFA states,           1966 NDFA arcs
      453 DFA states,            1966 DFA arcs
      351 minimal DFA states,    1562 minimal DFA arcs
      360 all insns          7 insn equivalence classes
    0 locked states
 1901 transition comb vector els,  2457 trans table els: use simple vect
 2457 min delay table els, compression factor 2

Automaton `thunderx2t99_ldst'
       41 NDFA states,            163 NDFA arcs
       41 DFA states,             163 DFA arcs
       14 minimal DFA states,      78 minimal DFA arcs
      360 all insns          8 insn equivalence classes
    0 locked states
   83 transition comb vector els,   112 trans table els: use simple vect
  112 min delay table els, compression factor 4

Automaton `thunderx2t99_mult'
        2 NDFA states,              5 NDFA arcs
        2 DFA states,               5 DFA arcs
        2 minimal DFA states,       5 minimal DFA arcs
      360 all insns          3 insn equivalence classes
    0 locked states
    6 transition comb vector els,     6 trans table els: use simple vect
    6 min delay table els, compression factor 8
============================================================

>> You'll want to update this to use your new scheduling model :-).

Done. I had overlooked it :-).

>> you should be changing vulcan to use the new thunderx2t99 model. 

Done. Using the new thunderx2t99 model.

Please review the modified patch and let us know your comments on the same.

Thanks,
Naveen

Attachment: thunderx2t99-scheduler.patch
Description: thunderx2t99-scheduler.patch

Reply via email to